New metadata deployed task fix #1588

ericallam · 2025-01-08T20:34:54Z

Summary by CodeRabbit

Bug Fixes
- Improved parameter handling and flexibility in the metadata update service.
- Simplified metadata processing logic in task run finalization.
Refactor
- Adjusted method signatures for better organization and clarity.
- Removed unnecessary CSV streaming and row processing functionality.
Chores
- Enhanced logging throughout the service for better debugging and monitoring.

changeset-bot · 2025-01-08T20:34:58Z

⚠️ No Changeset found

Latest commit: badf513

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-01-08T20:35:02Z

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts

Oops! Something went wrong! :(

ESLint: 8.45.0

ESLint couldn't find the config "custom" to extend from. Please check that the name of the config is correct.

The config "custom" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

This pull request introduces changes across multiple files in the webapp and references projects, primarily focusing on modifying the metadata update service and its invocation. The main modifications involve adjusting the parameter order for metadata update methods, making the environment parameter optional, and adding logging functionality. Additionally, some code related to CSV handling in a realtime reference project has been removed, simplifying the streaming and row processing logic.

Changes

File	Change Summary
`apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts`	Reordered parameters for `updateMetadataService.call` function
`apps/webapp/app/services/metadata/updateMetadata.server.ts`	Made `environment` parameter optional in `call` method, added debug logging to various methods
`apps/webapp/app/v3/services/finalizeTaskRun.server.ts`	Simplified conditional check for metadata update, adjusted parameter order
`references/nextjs-realtime/src/trigger/csv.ts`	Removed code for handling successful CSV rows and streaming metadata

Sequence Diagram

sequenceDiagram
    participant Client
    participant UpdateMetadataService
    participant Database

    Client->>UpdateMetadataService: call(runId, body, [environment])
    alt Environment provided
        UpdateMetadataService->>Database: Query with environment filter
    else No environment
        UpdateMetadataService->>Database: Query without environment filter
    end
    Database-->>UpdateMetadataService: Return result
    UpdateMetadataService-->>Client: Return updated metadata

Possibly related PRs

Add ability to update parent and root run metadata from children #1563: Modifies the updateMetadataService.call function's parameter order, enabling metadata updates from child runs

Poem

🐰 Metadata dance, parameters shift
Logs bloom like spring, code gets a lift
Environment optional, queries refined
Flexibility's magic, now intertwined
A rabbit's code leap, elegant and swift! 🌈

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54a00cf and badf513.

📒 Files selected for processing (4)

apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts (1 hunks)
apps/webapp/app/services/metadata/updateMetadata.server.ts (5 hunks)
apps/webapp/app/v3/services/finalizeTaskRun.server.ts (1 hunks)
references/nextjs-realtime/src/trigger/csv.ts (0 hunks)

Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-01-08T20:42:02Z

@trigger.dev/build

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1588

@trigger.dev/react-hooks

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1588

@trigger.dev/core

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1588

trigger.dev

npm i https://pkg.pr.new/triggerdotdev/trigger.dev@1588

@trigger.dev/rsc

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1588

@trigger.dev/sdk

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1588

commit: badf513

ericallam added 2 commits January 8, 2025 22:41

Add more logging around new metadata system

f0d836f

Make the authenticated env optional when updating run metadata

badf513

ericallam force-pushed the metadata-upgrade-logging branch from 54a00cf to badf513 Compare January 8, 2025 22:41

ericallam merged commit ab69b60 into main Jan 8, 2025
6 of 7 checks passed

ericallam deleted the metadata-upgrade-logging branch January 8, 2025 22:42

This was referenced Jan 9, 2025

New metadata system doc updates #1590

Merged

Support ignoring test/spec files inside trigger dirs (fixes #1593) #1596

Merged

Fix: Prevent failed resumes for very large batches #1598

Merged

Handle errors thrown by requests in Realtime react hooks #1599

Merged

coderabbitai bot mentioned this pull request Feb 11, 2025

When deploying, batch the "Waiting for deploy runs #1693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

New metadata deployed task fix #1588

New metadata deployed task fix #1588

Uh oh!

ericallam commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jan 8, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jan 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

New metadata deployed task fix #1588

New metadata deployed task fix #1588

Uh oh!

Conversation

ericallam commented Jan 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Poem

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ericallam commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 8, 2025 •

edited

Loading

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jan 8, 2025 •

edited

Loading